Add options for Logs #4374
Open
Add options for Logs #4374
+351
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
7 tasks
lcian
approved these changes
May 7, 2025
lbloder
approved these changes
May 9, 2025
| @@ -150,6 +152,9 @@ public final class ExternalOptions { | |||
| options.setCaptureOpenTelemetryEvents( | |||
| propertiesProvider.getBooleanProperty("capture-open-telemetry-events")); | |||
|
|
|||
| options.setEnableLogs(propertiesProvider.getBooleanProperty("logs.enabled")); | |||
There was a problem hiding this comment.
could also be experimental
| @@ -25,6 +25,7 @@ public final class ExternalOptions { | |||
| private @Nullable Boolean enableDeduplication; | |||
| private @Nullable Double tracesSampleRate; | |||
| private @Nullable Double profilesSampleRate; | |||
| private @Nullable Double logsSampleRate; | |||
There was a problem hiding this comment.
to be removed as we don't sample logs
| * 1.0. if 1.0 is set it means that 100% of items are sent. If set to 0.1 only 10% of items will | ||
| * be sent. Items are picked randomly. Default is 1.0 | ||
| */ | ||
| @ApiStatus.Experimental private @Nullable Double sampleRate = 1.0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
sampleRatefor Logs again as there's some discussion around whether this is actually useful in its current state where it just randomly drops log events without considering log level or the trace it belongs to.